Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow show subtitles using webkit Fullscreen API when playing native HLS #7539

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 5, 2024

No description provided.

@avelad avelad requested a review from tykus160 November 5, 2024 11:01
@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround labels Nov 5, 2024
@avelad avelad added this to the v4.12 milestone Nov 5, 2024
@avelad avelad merged commit 6ab6a8f into shaka-project:main Nov 5, 2024
17 checks passed
@avelad avelad deleted the ios-subtitles-fullscreen branch November 5, 2024 12:34
avelad added a commit that referenced this pull request Nov 12, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 4, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants