-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Fix absl log flags being stripped #1340
build: Fix absl log flags being stripped #1340
Conversation
According to a comment in packager/third_party/abseil-cpp/source/absl/log/CMakeLists.txt, many linkers will strip the contents of absl::log_flags because its symbols symbols are only used in a global constructor, and that for now, clients should link using $<LINK_LIBRARY:WHOLE_ARCHIVE,absl::log_flags>. Closes shaka-project#1325
I believe I have the docker builds fixed with the latest commit. PTAL! |
The windows shared build is failing with a
|
I've seen that before, and it doesn't make much sense, unless there is a race condition in the parallel build. I think if I re-run the failed job, it will pass, which could also point toward timing. |
It's not clear why the shared windows build is trying to build libpackager static. |
It always builds static, but only builds shared in the shared configuration. This is ever since #1293, but I don't remember the reasoning behind it. |
I'm going to file a new issue to look into this build flake, and I'll mention changes to the target structure as an option. |
According to a comment in
packager/third_party/abseil-cpp/source/absl/log/CMakeLists.txt, many linkers will strip the contents of absl::log_flags because its symbols symbols are only used in a global constructor, and that for now, clients should link using
$<LINK_LIBRARY:WHOLE_ARCHIVE,absl::log_flags>.
Closes #1325