Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix fake clock for muxer for integration tests #1322

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

cosmin
Copy link
Contributor

@cosmin cosmin commented Dec 25, 2023

The fix in #1289 was not complete and left the fake clock as null which didn't have any effect. This was revealed by integration tests showing mismatches in the timestamps in MP4.

@cosmin cosmin requested a review from joeyparrish December 26, 2023 06:10
@joeyparrish joeyparrish merged commit 9b9adf3 into shaka-project:main Feb 8, 2024
32 checks passed
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Apr 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants