fix: Fix type error in pssh-box.py with Python 3.10+ #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not 'str''
A single-line change on #L170 to `wv.protection_scheme = struct.unpack('>L', bytes(protection_scheme, encoding='utf-8'))[0]`, needed to work around this issue on Ubuntu 22.04LTS+ running Python 3.10+:
```sh
TypeError: a bytes-like object is required, not 'str'
```
On line 170.
Brainiarc7
changed the title
pssh-box.py
The patch has been updated to pass lint tests. The change is now within the line length limit(s).
|
Looks good. Thanks for contributing! |
joeyparrish
approved these changes
May 1, 2023
joeyparrish
changed the title
pssh-box.py
joeyparrish
pushed a commit
that referenced
this pull request
May 1, 2023
A single-line change on #L170 to `wv.protection_scheme =
struct.unpack('>L', bytes(protection_scheme, encoding='utf-8'))[0]`,
needed to work around this issue on Ubuntu 22.04LTS+ running Python
3.10+:
```sh
TypeError: a bytes-like object is required, not 'str'
```
On line 170.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single-line change on #L170 to
wv.protection_scheme = struct.unpack('>L', bytes(protection_scheme, encoding='utf-8'))[0], needed to work around this issue on Ubuntu 22.04LTS+ running Python 3.10+:TypeError: a bytes-like object is required, not 'str'On line 170.