Revert "lib/, src/: Use local time for human-readable dates"

[alejandro-colomar]

This reverts commit 3f5b4b5.

The dates are stored as UTC, and are stored as a number of days since Epoch. We don't have enough precision to translate it into local time. Using local time has caused endless issues in users.

This patch is not enough for fixing this issue completely, since printing a date without time-zone information means that the date is a local date, but what we're printing is a UTC date. A future patch should add time-zone information to the date.

For now, let's revert this change that has caused so many issues.

Fixes: 3f5b4b5 (2024-08-01; "lib/, src/: Use local time for human-readable dates")
Link: https://github.com/ansible/ansible/blob/devel/test/integration/targets/user/tasks/test_expires.yml#L2-L20
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095430
Link: https://lists.iana.org/hyperkitty/list/[email protected]/message/ENE5IFV3GAH6WK22UJ6YU57D6TQINSP5/
Link: #1202
Link: #1057
Link: #939
Link: #1058
Link: #1059 (comment)
Link: #952
Link: #942
Reported-by: @zeha
Reported-by: @kenion
Reported-by: @alejandro-colomar
Reported-by: @jubalh
Reported-by: @leegarrett
Cc: @eggert
Cc: @timparenti
Cc: @ikerexxe
Cc: @hallyn
Cc: @BrianInglis

---

Here goes the first round of changes. This reverts back to the old behavior.

---

Revisions:

v1b

• Rebase

$ git range-diff alx/master..gh/t shadow/master..t
1:  0f13c140 = 1:  e49f4a57 Revert "lib/, src/: Use local time for human-readable dates"

v1c

• Reviewed-by @ikerexxe

$ git range-diff master gh/t t 
1:  e49f4a57 ! 1:  a0c5dbd6 Revert "lib/, src/: Use local time for human-readable dates"
    @@ Commit message
         Reported-by: Lee Garrett <[email protected]>
         Cc: Paul Eggert <[email protected]>
         Cc: Tim Parenti <[email protected]>
    -    Cc: Iker Pedrosa <[email protected]>
         Cc: "Serge E. Hallyn" <[email protected]>
         Cc: Brian Inglis <[email protected]>
    +    Reviewed-by: Iker Pedrosa <[email protected]>
         Signed-off-by: Alejandro Colomar <[email protected]>
     
      ## lib/time/day_to_str.h ##

[alejandro-colomar]

Everyone affected by all the date-related bugs, can you please explicitly state if this change is good, bad, or neutral to your issues?

[zeha]

I've applied this revert on top of 4.17.2 and the problem described in #1202 is still there.

[alejandro-colomar]

I've applied this revert on top of 4.17.2 and the problem described in #1202 is still there.

Okay, I'll check that. Thanks for testing!

[alejandro-colomar]

@zeha

From what you've said in the bug report and here, this doesn't seem to affect neither positively nor negatively to your case. Since the change is technically good, and doesn't seem to make things worse, I'll re-open the PR for review.

Let's continue with the plan.

At least, this should allow you to see the real date that is being stored on file without having to look at the raw number in the shadow file.

[ikerexxe]

LGTM! Thanks for taking care of it.