Fixes #531 - Title retrieving is failing with multiple use case #532
Conversation
| 'ssl' => array( | ||
| 'verify_peer' => false, | ||
| 'verify_peer_name' => false, | ||
| 'allow_self_signed' => true |
There was a problem hiding this comment.
I'm not sure at all we should ignore SSL/TLS verification entirely...
There was a problem hiding this comment.
What's the potential risk?
There was a problem hiding this comment.
interesting read: PHP Security - Transport Layer Security
SSL/TLS should be enforced by default, with a possibility for users to disable it (at their own risk)
There was a problem hiding this comment.
I can't find a serious risk off the the top of my head, but bypassing security mechanisms tends to not end well. I agree that this should be optional.
There was a problem hiding this comment.
I did not take the time to read @virtualtam paper yet, but I don't think an option is necessary here. We can just remove TLS bypass.
|
Update:
<meta http-equiv="Content-Type" content="application/xhtml+xml;charset=iso-8859-1" /> |
| $this->assertEquals($target, getAbsoluteUrl($origin, $target)); | ||
| } | ||
|
|
||
| public function tmpTest() |
There was a problem hiding this comment.
But I like my empty test methods. :(
ArthurHoaro
force-pushed
the
hotfix/title-retrieve-the-return
branch
2 times, most recently
from
d32cb07 to
6e7db3b
Compare
ArthurHoaro
force-pushed
the
hotfix/title-retrieve-the-return
branch
from
6e7db3b to
ce7b0b6
Compare
| * @param string $url initial URL to reach. | ||
| * @param int $redirectionLimit max redirection follow.. | ||
| * @param string $url initial URL to reach. | ||
| * @param int $redirectionLimit max redirection follow.. |
see #531 for details
Almost everything is now working, except: