Draft: CI workflow update

[thican]

Avoid updates during CI, unexpected modifications happen, leading to job failures.

Should also be done for Docker images.

[nodiscc]

Is this the fix for #2126 ?

I did not have the time to investigate yet, tell me if you need help.

[thican]

Is this the fix for #2126 ?

Yes it is.

I did not have the time to investigate yet, tell me if you need help.

In fact I do.

This is actually more complicated than I anticipated, as I am not a PHP developer, so I might be providing a wrong solution. And because I was busy since my last commits, I could not investigate more.
As far as I understood, the composer.lock file is used for all the currently supported PHP versions. Because of this, some third-party updates are "stuck" in a previous version while the later branch releases can pull more recent version, hence the composer update instruction in CI.

From my experience, CI should not pull and update project’s dependencies, otherwise this kind of issues happens. But then, later branch release is stuck as mentioned earlier.

What do you think?

[thican]

Also, I forgot to mention, I don’t know which versions of dependencies match the actual code in the project, to I avoid to touch the content of composer.json.

[nodiscc]

Current CI failures have been fixed in #2135

As I noted there, there is still something wrong with our CI, it should not break all of a sudden, all dependencies should be pinned and never updated automatically. I will open an issue specifically for this.

[nodiscc]

See #2137