-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github actions: build OCI images that contain both amd64 and armv7 #1962
Conversation
nodiscc
commented
Mar 21, 2023
•
edited
Loading
edited
- ref. https://docs.docker.com/engine/reference/commandline/buildx_build/#platform
- ref. https://docs.docker.com/build/ci/github-actions/multi-platform/
- replaces Build Docker images that contain both amd64 and /arm/v7 #1496
- make docker image name configurable through CI variables for easier testing
f0a67b4
to
b14245b
Compare
- ref. https://docs.docker.com/engine/reference/commandline/buildx_build/#platform - ref. https://docs.docker.com/build/ci/github-actions/multi-platform/ - replaces shaarli#1496 - make docker image name configurable through CI variables for easier testing
Rebased, PR description updated. Verified that the resulting image contains both
I made the image name configurable through Github Actions CI variables/secrets, so I will now set I will now close #1496 since this PR replaces it. I have no way to test if the resulting image actually works (currently no ARM machine to run it, I will try to create an ARMv7 VM with libvirt/qemu but this might take some time). Maybe @cerebrate or other users with an ARM machine would be able to test |
Happy to do that testing. ...incidentally, since it's got a lot more popular since I was first noodling about with arm devices, maybe it's time to add arm64 to the build matrix also? |
Wouldn't it make sense to use a variable instead of a secret, since it's not sensitive information?
Agreed, and I happen to have a brand new arm64 chip to test it! Current behavior:
|
@nodiscc Looks to be running fine on my 32-bit ARM machine (Raspberry Pi). |
A plain variable would be more appropriate, but I used secrets since we already use them - this way the syntax stays consistent (https://docs.github.com/en/actions/learn-github-actions/variables vs https://docs.github.com/en/actions/security-guides/encrypted-secrets), and everything is immediately visible on Secrets and variables > Actions - I prefer consistency to correctness :) But feel free to change it. |