Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't import all links from my Delicious account #902

Closed
jpyrat opened this issue Jul 20, 2017 · 7 comments
Closed

Can't import all links from my Delicious account #902

jpyrat opened this issue Jul 20, 2017 · 7 comments
Assignees
Labels
bug it's broken! support installation and configuration issues tools developer tools
Milestone

Comments

@jpyrat
Copy link

jpyrat commented Jul 20, 2017

I just wanted to switch from https://del.icio.us/jpyrat (RIP) to shaarli
It blocks on certain contents
Like :

<DT><A HREF="http://wiki.kde.org/tiki-index.php?page=UserPagetoggg" ADD_DATE="1182269176" PRIVATE="0" TAGS="toggg">KDE Wiki : UserPagetoggg</A>
<DD>-----BEGIN GEEK CODE BLOCK-----
Version: 3.1
GE/CS/IT/O d-(pu) s: a+ C++$>+++$ UL++++ UA* P+ L+++ E?
W++ N++>- !o K? w---@ O? M+>++ V+$ PS+(++) PE-- Y-(+)
PGP>+ t 5? X-- R* !tv b+++ DI? !D G e++++ h---->++ r++++ y+
------END GEEK CODE BLOCK------
<DT><A HREF="http://p7app.geneve.ch/spip/article.php3?id_article=340" ADD_DATE="1182264859" PRIVATE="0" TAGS="spip,reference,formations">Une sélection de tutoriels pour maîtriser SPIP</A>
<DD>En complément au présent site, voici une liste non exhaustive d’excellents documents disponibles sur le Web pour maîtriser les volets Rédacteurs, Administrateurs et Webdéveloppeurs SPIP.
@virtualtam virtualtam added bug it's broken! support installation and configuration issues tools developer tools labels Jul 21, 2017
@virtualtam virtualtam added this to the 0.9.1 milestone Jul 21, 2017
@virtualtam virtualtam self-assigned this Jul 21, 2017
@virtualtam
Copy link
Member

Hi @jpyrat !

It blocks on certain contents

Does this issue only concern bookmarks containing code blocks / special chars? Or does it prevent you from importing other bookmarks?

@jpyrat
Copy link
Author

jpyrat commented Jul 22, 2017

I think that's the problem is with < and > not escaped
One other problem is that Delicious Export doesn't close tags :

<DT><A HREF="http://www.phpindex.com/index.php/2005/03/22/67-jdnet-ixarm-la-place-de-marche-publique-n1-en-europe" ADD_DATE="1182276040" PRIVATE="0" TAGS="SPIP,pro2spip">JDNet : Ixarm : la place de marché publique N°1 en Europe - PHP Index - La passerelle française des technologies PHP: Hypertext Preprocessor</A>
<DD>"La démarche de dématérialisation des marchés publics du ministère de la Défense (Mindef) est sans conteste l'une des plus abouties de l'administration française".
... B asés sur SPIP, APACHE, MySQL, PHP, nouvelle preuve de la reconnaissance de PH
<DT><A HREF="http://wiki.kde.org/tiki-index.php?page=UserPagetoggg" ADD_DATE="1182269176" PRIVATE="0" TAGS="toggg">KDE Wiki : UserPagetoggg</A>
<DD>-----BEGIN GEEK CODE BLOCK-----
Version: 3.1
GE/CS/IT/O d-(pu) s: a+ C++$>+++$ UL++++ UA* P+ L+++ E?
W++ N++>- !o K? w---@ O? M+>++ V+$ PS+(++) PE-- Y-(+)
PGP>+ t 5? X-- R* !tv b+++ DI? !D G e++++ h---->++ r++++ y+
------END GEEK CODE BLOCK------
<DT><A HREF="http://p7app.geneve.ch/spip/article.php3?id_article=340" ADD_DATE="1182264859" PRIVATE="0" TAGS="spip,reference,formations">Une sélection de tutoriels pour maîtriser SPIP</A>
<DD>En complément au présent site, voici une liste non exhaustive d’excellents documents disponibles sur le Web pour maîtriser les volets Rédacteurs, Administrateurs et Webdéveloppeurs SPIP.

Does this help ?

@virtualtam
Copy link
Member

virtualtam commented Jul 23, 2017

Yup, it's very likely to come from < and > signs in the bookmark description being considered as closing tags by the NetccapeBookmarkParser utility.

Modifying the parser code to support such content is quite unlikely to be straightforward, hence my question:

Does this issue only concern bookmarks containing code blocks / special chars? Or does it prevent you from importing other bookmarks?

Unless you have a lot of links with similar code blocks, I'd recommend:

  • curating the Delicious dump so Shaarli can import every other link
  • manually adding the aforementioned bookmarks through Shaarli's interface

Anyway, I might have time next week to do some tests with https://github.com/shaarli/netscape-bookmark-parser , feel free to post other relevant exports :)

@jpyrat
Copy link
Author

jpyrat commented Jul 23, 2017

The delicious export contains 12000 links !

If needed, I can provide it in order to help shaarli debuging ;-)

@virtualtam
Copy link
Member

O_o

12, 000 sure counts as a lot of links... and will make for a nice parsing exercise ;-)

@jpyrat
Copy link
Author

jpyrat commented Jul 23, 2017

And here is the nice parsing exercice ;-)
delicious_export_20170614 (original).zip

@virtualtam virtualtam modified the milestones: 0.9.1, 0.9.2 Aug 3, 2017
virtualtam added a commit to shaarli/devtools that referenced this issue Oct 4, 2017
It uses the Faker library to generate fake yet coherent bookmark entries that
can then be used to:
- test Shaarli bookmark imports
- test NetscapeBookmarkParser
- diagnose performance issues

See:
- https://faker.readthedocs.io/en/latest/
- shaarli/Shaarli#902
- shaarli/Shaarli#969
- https://github.com/shaarli/netscape-bookmark-parser

Signed-off-by: VirtualTam <[email protected]>
@ArthurHoaro ArthurHoaro modified the milestones: 0.9.2, 0.9.3 Oct 7, 2017
@virtualtam virtualtam modified the milestones: 0.9.3, 0.10.0 Oct 22, 2017
@ArthurHoaro ArthurHoaro modified the milestones: 0.10.0, 0.9.4 Jan 30, 2018
@jpyrat
Copy link
Author

jpyrat commented May 16, 2018

The import worked for me with 0.9.6.
Just one regression from delicious : tags with space are imported as separates tags :( (because shaarli doesn't handle tags with spaces)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug it's broken! support installation and configuration issues tools developer tools
Projects
None yet
Development

No branches or pull requests

3 participants