Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlickR links break the UI #512

Closed
ArthurHoaro opened this issue Mar 7, 2016 · 6 comments
Closed

FlickR links break the UI #512

ArthurHoaro opened this issue Mar 7, 2016 · 6 comments
Labels
bug it's broken!
Milestone
0.7.0

Comments

@ArthurHoaro
Copy link
Member

Title discovery fails with flickr.com, breaking the UI.

Example: https://www.flickr.com/photos/westendfoto/25448713131/in/explore-2016-03-06/
Result on my instance:

Demo instance:
@ArthurHoaro ArthurHoaro added the bug it's broken! label Mar 7, 2016
@ArthurHoaro ArthurHoaro added this to the 0.7.0 milestone Mar 7, 2016
@mro
Copy link

mro commented Mar 7, 2016

must be a regression, works fine over at https://github.com/mro/Shaarli/commit/b9c0e1632b8c2e41dd89d0a21c1ae708835f91d0, see https://links.mro.name/?n1lCVg

@ArthurHoaro
Copy link
Member Author

Oh. Then the regression might come from 1557cef.

@mro
Copy link

mro commented Mar 8, 2016

you are not a fan of fine-grained commit, are you?

@mro
Copy link

mro commented Mar 8, 2016

IMO would be a great candidate for a unit test.

@ArthurHoaro ArthurHoaro mentioned this issue Mar 8, 2016
Merged
@mro
Copy link

mro commented Mar 9, 2016

chapeau, très élégant!

@ArthurHoaro
Copy link
Member Author

It would even have been better if I didn't break the regex in the first place, but thanks.

virtualtam added a commit that referenced this issue Mar 14, 2016
@virtualtam
Merge pull request #513 from ArthurHoaro/hotfix/retrieve-title-issue
5816801 
Fixes #512: retrieving title didn't match the first closing tag
@ArthurHoaro ArthurHoaro mentioned this issue Mar 27, 2016
Closed
@julienCXX julienCXX mentioned this issue Apr 5, 2016
Open
33 tasks
portailp pushed a commit to PortailPro/Shaarli that referenced this issue Mar 20, 2017
@ArthurHoaro @portailp
Fixes shaarli#512: retrieving title didn't match the first closing tag
bd89c9e
portailp added a commit to PortailPro/Shaarli that referenced this issue Mar 20, 2017
@portailp
Revert "Fixes shaarli#512: retrieving title didn't match the first cl…
b2f1486 
…osing tag"

This reverts commit bd89c9e.
portailp added a commit to PortailPro/Shaarli that referenced this issue Mar 20, 2017
@portailp
Revert "Fixes shaarli#512: retrieving title didn't match the first cl…
23166c5 
…osing tag"

This reverts commit bd89c9e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug it's broken!
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@mro @ArthurHoaro