Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved apis for easier adoption #3

Merged
merged 1 commit into from
May 27, 2021
Merged

improved apis for easier adoption #3

merged 1 commit into from
May 27, 2021

Conversation

sha1n
Copy link
Owner

@sha1n sha1n commented May 27, 2021

No description provided.

* migrated spinner to depend on a stringwritter rather than a terminal for easier adoption
* migrated matrix to return io.writer/stringwriter instead of a proprietary interface
* updated demo app
@coveralls
Copy link

coveralls commented May 27, 2021

Pull Request Test Coverage Report for Build 882298456

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 71 of 81 (87.65%) changed or added relevant lines in 5 files are covered.
  • 20 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+1.7%) to 81.725%

Changes Missing Coverage Covered Lines Changed/Added Lines %
matrix.go 43 45 95.56%
spinner.go 5 7 71.43%
terminal.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
fake_terminal.go 1 70.45%
internal/main.go 1 95.05%
spinner.go 1 96.55%
terminal.go 17 0.0%
Totals Coverage Status
Change from base Build 882075514: 1.7%
Covered Lines: 398
Relevant Lines: 487

💛 - Coveralls

@sha1n sha1n merged commit 40d341a into master May 27, 2021
@sha1n sha1n deleted the laboratory branch May 27, 2021 14:40
sha1n added a commit that referenced this pull request Sep 24, 2021
* migrated spinner to depend on a stringwritter rather than a terminal for easier adoption
* migrated matrix to return io.writer/stringwriter instead of a proprietary interface
* updated demo app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants