Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e5-mistral embedding model - step 3/3 #988

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Add e5-mistral embedding model - step 3/3 #988

merged 2 commits into from
Aug 8, 2024

Conversation

Ying1123
Copy link
Member

@Ying1123 Ying1123 commented Aug 8, 2024

This is the last PR contains unit test after

Note: does not support input is a list of prompts

@Ying1123 Ying1123 force-pushed the ying-e5-mistral branch 2 times, most recently from 79e4bcd to c961031 Compare August 8, 2024 08:06
@Ying1123 Ying1123 requested a review from merrymercy August 8, 2024 08:12
@merrymercy
Copy link
Contributor

This PR introduces too many if/else. Follow this principle to refactor them

  1. If there is a if/else branch, make sure the generation branch is the first one
  2. If possible, always use if is_generation instead of if not is_embedding

@Ying1123 Ying1123 mentioned this pull request Aug 8, 2024
29 tasks
@Ying1123 Ying1123 force-pushed the ying-e5-mistral branch 11 times, most recently from ead6e1f to 84306a9 Compare August 8, 2024 21:56
@Ying1123 Ying1123 force-pushed the ying-e5-mistral branch 2 times, most recently from 881fa81 to 189626c Compare August 8, 2024 23:12
@Ying1123 Ying1123 merged commit e040a24 into main Aug 8, 2024
4 checks passed
@Ying1123 Ying1123 deleted the ying-e5-mistral branch August 8, 2024 23:31
@Ying1123 Ying1123 mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants