-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor flashinfer logic for deepseek v3 and fix accuracy bug #3785
Merged
+565
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzh119
reviewed
Feb 23, 2025
yzh119
reviewed
Feb 23, 2025
5 tasks
zhyncs
reviewed
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
flashinfer_backend.py
for attention is too complex, this PR extract the logic of MLA and creates a newflashinfer_mla_backend.py
Also, #3716 #3751 reports an accuracy bug when enabling flashinfer mla. This PR solves this bug by correctly handling rope scaling with yarn, with the help of @yzh119.
Modifications
FlashInferMLAAttnBackend
inflashinfer_mla_backend.py
by removing codes irrelevant to MLA inflashinfer_backend.py
auto
so the newest fa3 backend of flashinfer can be usedAccuracy Test
The baseline results of not enabling flashinfer mla can be referred to #3486.
Server
gsm8k
mmlu
Checklist