Peer reviewers #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Karthik Bandagonda <[email protected]>
Co-authored-by: sgfost <[email protected]>
- use get_or_create to update a reviewer when trying to create while one already exists - allow users to create or update their own reviewer record. this allows anyone to insert themselves into the reviewer pool at any time, should consider whether this is desirable or we should add a pending status Co-authored-by: Karthik Bandagonda <[email protected]>
This prevents the reviewer object on the parent component from being mutated before the form is submitted
permission class was not set up properly, now correctly drops through to has_object_permission for retrieve, update, etc. * add a profile link to reviewer card
provide string representation of PeerReviewer
sgfost
force-pushed
the
peer-reviewers
branch
from
77a705c to
cf7f9ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.