Add defaultName for saving .js or .zip #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgenoud
reviewed
Jan 11, 2025
| export default (code, fileName) => { | ||
| fileName = fileName ?? 'replicad-script' | ||
| export default async (code, fileName) => { | ||
| fileName = fileName |
There was a problem hiding this comment.
Are you sure this does something? I feel like it always take the name of the first export
There was a problem hiding this comment.
const shapeName =
store.currentMesh.length === 1 ? store.currentMesh[0]?.name : null;
return downloadCode(store.code.current, shapeName);It'll use the shape name if there is only 1 shape and only if it has a name, then it will use the defaultName then it will fallback to replicad-script.
There was a problem hiding this comment.
Would defaultName ?? shapeName ?? 'replicad-script' be a better order?
There was a problem hiding this comment.
Yeah, I think this would be a better order (as all shapes get a name by default).
|
Thanks! I will do a couple of changes on my end to support the case where there is only one shape. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows exporting
defaultNamewhich will be used when saving.jsor.zipfilesFixes #177