Better error handling in cert generation #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhbit
force-pushed
the
cert-gen-cleanup
branch
2 times, most recently
from
193ed26 to
d47c771
Compare
|
Ping. |
|
LGTM, but needs a rebase |
Now it should correctly free all resources in case of failure.
vhbit
force-pushed
the
cert-gen-cleanup
branch
from
d47c771 to
72ee42a
Compare
|
Rebased. |
sfackler
added a commit
that referenced
this pull request
Oct 6, 2014
Better error handling in cert generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it should correctly free all resources in case
of failure.