Use DH_generate_parameters_ex() #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nospam3089
force-pushed
the
fix/modern_generate_parameters
branch
from
e692762 to
b6584dd
Compare
sfackler
reviewed
Mar 11, 2021
openssl/src/dh.rs
Outdated
| @@ -77,15 +77,18 @@ impl Dh<Params> { | |||
| /// | |||
| /// This corresponds to [`DH_generate_parameters`]. | |||
There was a problem hiding this comment.
Suggested change
| /// This corresponds to [`DH_generate_parameters`]. | |
| /// This corresponds to [`DH_generate_parameters_ex`]. |
There was a problem hiding this comment.
Good catch! That's an excellent improvement. I've re-pushed the branch with this change included. Thank you!
https://www.openssl.org/docs/man1.1.0/man3/DH_generate_parameters.html states that DH_generate_parameters() is deprecated. It has been so since OpenSSL 0.9.8 was released in 2005.
nospam3089
force-pushed
the
fix/modern_generate_parameters
branch
from
b6584dd to
62acbe3
Compare
sfackler
reviewed
Mar 12, 2021
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.openssl.org/docs/man1.1.0/man3/DH_generate_parameters.html
states that DH_generate_parameters() is deprecated. It has been so since
OpenSSL 0.9.8 was released in 2005.