Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should p-s stop executing commands when an error occurs? #48

Closed
tleunen opened this issue Aug 22, 2016 · 2 comments
Closed

Should p-s stop executing commands when an error occurs? #48

tleunen opened this issue Aug 22, 2016 · 2 comments
Labels
bug enhancement help wanted

Comments

@tleunen
Copy link
Collaborator

tleunen commented Aug 22, 2016

I wonder if p-s should stop the execution when an error occurs when executing multiple commands (in parallel or not).

Any thoughts?

Especially when p-s run a command and then the second command depends on the first one...
@kentcdodds
Copy link
Collaborator

Yes it should. I thought about this just recently. I'm happy to accept a pull request to do this!

@kentcdodds
Copy link
Collaborator

I think I'd like to get this done before working on this.

@kentcdodds kentcdodds mentioned this issue Sep 3, 2016
Merged
kentcdodds pushed a commit that referenced this issue Sep 4, 2016
fix(error): when an error occurs, stop processes
c911c67 
This is a significant refactor to make it so when an error occurs in one
parallel script, the others are killed and also to ensure that an error
in one serial script will result in the others not being executed.

Closes #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kentcdodds @tleunen