Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow column config #543

Merged
merged 1 commit into from
Jan 22, 2025
Merged

feat: allow column config #543

merged 1 commit into from
Jan 22, 2025

Conversation

roderik
Copy link
Member

@roderik roderik commented Jan 22, 2025

Summary by Sourcery

New Features:

  • Introduced a new way to configure the columns displayed in the asset table.

Copy link

sourcery-ai bot commented Jan 22, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new way to configure columns in the AssetTable component. Instead of having a single function that returns all columns, the columns are now defined as individual constants and a function that returns a default set of columns. This allows for more flexibility in which columns are displayed in the table.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Refactor asset table columns into individual column definitions.
  • The assetTableColumns function was removed.
  • Individual column definitions were created for 'id', 'name', 'symbol', 'decimals', and 'totalSupply'.
  • A detailsColumn function was created to handle the actions column.
  • A defaultAssetTableColumns function was created to return a default set of columns.
kit/dapp/src/components/blocks/asset-table/asset-table-columns.tsx
Update AssetTableClient and AssetTable components to accept columns as a prop.
  • The AssetTableClient component now accepts a columns prop.
  • The AssetTable component now passes the columns prop to the AssetTableClient component.
  • The assetTableColumns function is no longer used in these components.
kit/dapp/src/components/blocks/asset-table/asset-table-client.tsx
kit/dapp/src/components/blocks/asset-table/asset-table.tsx
Update admin pages to use the new column configuration.
  • The AssetTable component now receives the defaultAssetTableColumns as a prop.
kit/dapp/src/app/(private)/admin/cryptocurrencies/page.tsx
kit/dapp/src/app/(private)/admin/bonds/page.tsx
kit/dapp/src/app/(private)/admin/stablecoins/page.tsx
kit/dapp/src/app/(private)/admin/equities/page.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the feat label Jan 22, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @roderik - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@roderik roderik merged commit 59452bf into main Jan 22, 2025
3 checks passed
@roderik roderik deleted the rvdv-branch-2 branch January 22, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant