Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: colors #1194

Merged
merged 2 commits into from
Mar 20, 2025
Merged

fix: colors #1194

merged 2 commits into from
Mar 20, 2025

Conversation

pmualaba
Copy link
Contributor

@pmualaba pmualaba commented Mar 20, 2025

Summary by Sourcery

Updates the color palette to improve contrast and fix inconsistencies. This includes changes to the card, muted, and sidebar-menu-button colors.

Bug Fixes:

  • Fixes inconsistencies in the color palette.
  • Improves color contrast for better readability.

@pmualaba pmualaba self-assigned this Mar 20, 2025
Copy link

sourcery-ai bot commented Mar 20, 2025

Reviewer's Guide by Sourcery

This pull request modifies the color scheme of the application by adjusting the CSS variables to align with the design system. It also updates the styling of sidebar menu buttons to apply the bg-sidebar-accent class when the font is bold.

Updated class diagram for the color scheme

classDiagram
    class CSSVariables {
        --background: var(--sm-background-lightest)
        --foreground: var(--sm-text)
        --card: var(--sm-colored-shadow)
        --card-foreground: var(--sm-text)
        --popover: var(--sm-background-lightest)
        --popover-foreground: var(--sm-text)
        --primary: var(--sm-graphics-primary)
        --primary-foreground: var(--sm-text-contrast)
        --secondary: var(--sm-graphics-primary)
        --secondary-foreground: var(--sm-text)
        --muted: var(--sm-colored-shadow)
        --muted-foreground: var(--sm-muted)
        --accent: var(--sm-accent)
        --accent-foreground: var(--sm-text-contrast)
        --destructive: var(--sm-error)
        --destructive-foreground: var(--sm-text-contrast)
        --border: var(--sm-border)
        --input: var(--sm-input)
        --ring: var(--sm-ring)
    }

    note for CSSVariables "--card changed from var(--sm-background-gradient-start) to var(--sm-colored-shadow)\n--muted changed from var(--sm-muted) to var(--sm-colored-shadow)"
Loading

File-Level Changes

Change Details Files
Updated CSS variables for background, card, and muted elements to align with the design system's color scheme.
  • Changed --card from var(--sm-background-gradient-start) to var(--sm-colored-shadow).
  • Changed --muted from var(--sm-muted) to var(--sm-colored-shadow).
kit/dapp/src/app/globals.css
Modified the styling of sidebar menu buttons to apply the bg-sidebar-accent class when the font is bold.
  • Added [data-slot="sidebar-menu-button"].font-bold to the selector that applies the bg-sidebar-accent class.
kit/dapp/src/app/globals.css

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pmualaba - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@roderik roderik merged commit a155dfb into main Mar 20, 2025
6 checks passed
@roderik roderik deleted the patrick/eng-2714-wrong-tab-border-color branch March 20, 2025 11:43
snigdha920 added a commit that referenced this pull request Mar 20, 2025
…n-portfolio-section

* main:
  fix: AssetType translation for tokenizeddeposit (#1200)
  chore(deps): update dependency @scalar/api-reference-react to v0.6.4 (#1199)
  feat: bond yield charts (#1197)
  fix: update create asset (#1195)
  fix: colors (#1194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants