-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: colors #1194
fix: colors #1194
Conversation
Reviewer's Guide by SourceryThis pull request modifies the color scheme of the application by adjusting the CSS variables to align with the design system. It also updates the styling of sidebar menu buttons to apply the Updated class diagram for the color schemeclassDiagram
class CSSVariables {
--background: var(--sm-background-lightest)
--foreground: var(--sm-text)
--card: var(--sm-colored-shadow)
--card-foreground: var(--sm-text)
--popover: var(--sm-background-lightest)
--popover-foreground: var(--sm-text)
--primary: var(--sm-graphics-primary)
--primary-foreground: var(--sm-text-contrast)
--secondary: var(--sm-graphics-primary)
--secondary-foreground: var(--sm-text)
--muted: var(--sm-colored-shadow)
--muted-foreground: var(--sm-muted)
--accent: var(--sm-accent)
--accent-foreground: var(--sm-text-contrast)
--destructive: var(--sm-error)
--destructive-foreground: var(--sm-text-contrast)
--border: var(--sm-border)
--input: var(--sm-input)
--ring: var(--sm-ring)
}
note for CSSVariables "--card changed from var(--sm-background-gradient-start) to var(--sm-colored-shadow)\n--muted changed from var(--sm-muted) to var(--sm-colored-shadow)"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pmualaba - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Updates the color palette to improve contrast and fix inconsistencies. This includes changes to the card, muted, and sidebar-menu-button colors.
Bug Fixes: