Fixed an issue where calls are not working on locked screen #329
Conversation
…pp state is not in background
RyanRory
changed the title
RyanRory
changed the title
| @@ -340,12 +334,16 @@ public enum PushRegistrationError: Error { | |||
| return | |||
| } | |||
|
|
|||
| JobRunner.appDidBecomeActive() | |||
There was a problem hiding this comment.
Is this to ensure messages are sending correctly? Does JobRunner.appDidFinishLaunching() end up getting called if the app starts via this entry point? (Just wondering if there are edge-cases we might need to handle by triggering this directly, or if executers that are setup in AppDelegate might not have been yet)
Since we are calling startPollersIfNeeded below is there anything else in AppDelegate.handleActivation() that we should be doing in here that we aren't?
There was a problem hiding this comment.
Regarding this one, I found that the message sending and receiving jobs were not running at all when app is started by VOIP. JobRunner.appDidFinishLaunching() is called but AppDelegate.handleActivation() is not called. And I think there are 2 reasons that the message sending and receiving jobs were not running:
- Job queues were not activated.
- Job.canRun was set to false because app state is
.inactive.
Besides, the processes of app launching and handling VOIP are concurrent, we need to do necessary things in the VOIP handling process to make sure and calls can get connected in time.
No description provided.