-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing a single string as a sequence<DOMString> generates a Vec<DOMString> #19776
Labels
A-content/bindings
The DOM bindings
Comments
3 tasks
https://heycam.github.io/webidl/#es-sequence defines that a WebIDL |
I am not sure ... whatwg/webidl#266 Is DOMString a string wrapper? |
bors-servo
pushed a commit
that referenced
this issue
Jan 17, 2018
Do not throw if PerformanceObserver.observe gets an empty sequence Apply this spec change: w3c/performance-timeline#88 Some tests change from FAIL to TIMEOUT, which is expected as we still don't support the Resource or the Navigation Timing APIs. And the "entryTypes must be a sequence or throw a TypeError" fails because of #19776. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19777) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Jan 18, 2018
Do not throw if PerformanceObserver.observe gets an empty sequence Apply this spec change: w3c/performance-timeline#88 Some tests change from FAIL to TIMEOUT, which is expected as we still don't support the Resource or the Navigation Timing APIs. And the "entryTypes must be a sequence or throw a TypeError" fails because of #19776. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19777) <!-- Reviewable:end -->
Can't reproduce this: new MutationObserver(() => {}).observe(document.body, { attributeFilter: "abc" });
// TypeError: Value is not an object, as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With an interface like:
passing a single string like:
generates a
[DOMString("s"), DOMString("t"), DOMString("r"), DOMString("i"), DOMString("n"), DOMString("g")]
.I believe this should throw a TypeError instead, like in https://github.com/w3c/web-platform-tests/blob/master/performance-timeline/po-observe.any.js#L12
The text was updated successfully, but these errors were encountered: