Make match_ignore_ascii_case! future-proof. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the usage syntax to require a comma on the last non-fallback arm, which is a [breaking-change]. The old definition has started to emit a warning in recent nightlies and is likely to be an error in future versions: rust-lang/rfcs#1384 The new definition is recursive to resolve ambiguities. Unfortunately this makes error reporting terrible: rust-lang/rust#31022
|
@bors-servo r+ |
|
📌 Commit 0c78da0 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 19, 2016
Make match_ignore_ascii_case! future-proof. Change the usage syntax to require a comma on the last non-fallback arm, which is a [breaking-change]. The old definition has started to emit a warning in recent nightlies and is likely to be an error in future versions: rust-lang/rfcs#1384 The new definition is recursive to resolve ambiguities. Unfortunately this makes error reporting terrible: rust-lang/rust#31022 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/91) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Jan 19, 2016
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 19, 2016
Update cssparser. servo/rust-cssparser#91 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9380) <!-- Reviewable:end -->
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Jan 19, 2016
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 19, 2016
Update cssparser. servo/rust-cssparser#91 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9380) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 20, 2016
Update cssparser. servo/rust-cssparser#91 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9380) <!-- Reviewable:end -->
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Jan 21, 2016
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 21, 2016
Update cssparser. servo/rust-cssparser#91 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9380) <!-- Reviewable:end -->
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Jan 21, 2016
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 21, 2016
Update cssparser. servo/rust-cssparser#91 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9380) <!-- Reviewable:end -->
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…onSapin servo/rust-cssparser#91 Source-Repo: https://github.com/servo/servo Source-Revision: 1ba1fb0b7f46472e1f37f4e3f2e7dde025fa9f1f UltraBlame original commit: 9dc742835b57cb0d99cf8d0966bedcaa3e9c28c4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…onSapin servo/rust-cssparser#91 Source-Repo: https://github.com/servo/servo Source-Revision: 1ba1fb0b7f46472e1f37f4e3f2e7dde025fa9f1f UltraBlame original commit: 9dc742835b57cb0d99cf8d0966bedcaa3e9c28c4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…onSapin servo/rust-cssparser#91 Source-Repo: https://github.com/servo/servo Source-Revision: 1ba1fb0b7f46472e1f37f4e3f2e7dde025fa9f1f UltraBlame original commit: 9dc742835b57cb0d99cf8d0966bedcaa3e9c28c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the usage syntax to require a comma on the last non-fallback arm, which is a [breaking-change].
The old definition has started to emit a warning in recent nightlies and is likely to be an error in future versions: rust-lang/rfcs#1384
The new definition is recursive to resolve ambiguities. Unfortunately this makes error reporting terrible: rust-lang/rust#31022