Fixed Windows jsglue
Builds with Define for Built-in offsetof
#550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-D_CRT_USE_BUILTIN_OFFSETOF
forjsglue
during thebindgen
phase.When building for
aarch64-pc-windows-msvc
with llvm 19, I had 12 errors as a result ofoffsetof
not beingconstexpr
compatible.Examples of code which caused the errors:
https://searchfox.org/mozilla-central/source/js/public/Proxy.h#459
https://searchfox.org/mozilla-central/source/mfbt/HashFunctions.h#367