Interactive CLI interactive hook #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschep
force-pushed
the
interactivecli-interactive-hook
branch
from
80a9647 to
049434b
Compare
medikoo
previously requested changes
Aug 16, 2019
dschep
force-pushed
the
interactivecli-interactive-hook
branch
from
049434b to
a0ed7eb
Compare
medikoo
previously approved these changes
Aug 16, 2019
medikoo
reviewed
Aug 17, 2019
pmuens
approved these changes
Aug 26, 2019
pmuens
changed the title
pmuens
previously requested changes
Aug 26, 2019
There was a problem hiding this comment.
Also I wouldn't bump any versions here.. as this requires cherry-picked release branch preparation (we already have some new features in
masterafter 1.50.0 was released)
Update the review as it makes sense to keep the 1.50.0 version as @medikoo mentioned above.
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "serverless", | |||
| "version": "1.50.0", | |||
There was a problem hiding this comment.
We could keep the old version here to avoid cherry-picking as @medikoo mentioned in his PR review.
medikoo
approved these changes
Aug 26, 2019
dschep
added a commit
that referenced
this pull request
Aug 26, 2019
* PLAT-1391 - add interactiveCli:end lifecycle hook (cherry picked from commit 843650d)
dschep
added a commit
that referenced
this pull request
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Added
interactiveCli:endlifecycle hook to enable serverless/enterprise-plugin#226How did you implement it:
added
'end'lifecycle hook to the interactiveCli pluginHow can we verify it:
checkout this branch and use the plugin from the other pr and try the sls interactive flow, you should get the messages at the end.
Todos:
Note: Run
npm run test-cito run all validation checks on proposed changesValidate via
npm testValidate via
npm run lint-updatedNote: Some reported issues can be automatically fixed by running
npm run lint:fixValidate via
npm run prettier-check-updatedNote: All reported issues can be automatically fixed by running
npm run prettify-updatedIs this ready for review?: YES
Is it a breaking change?: NO