Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement logging with Log4j2 for aws-scala-sbt #6078

Merged
merged 3 commits into from
May 6, 2019

Conversation

NomadBlacky
Copy link

What did you implement:

Closes #XXXXX

How did you implement it:

How can we verify it:

$ sls create -t aws-scala-sbt -p sls-scala
$ cd sls-scala
$ sbt assembly
$ sls deploy
$ sls invoke -f hello
$ sls logs -f hello # Please check to log from the function.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.9")
addSbtPlugin("com.github.nomadblacky" % "sbt-assembly-log4j2" % "0.1.1")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A sbt-plugin has been released that merges Log4j2Plugins.dat.

However, it doesn't support sbt 1.x.
I released a fork that supports sbt 1.x.

@pmuens pmuens self-assigned this May 6, 2019
@pmuens pmuens added this to the 1.42.0 milestone May 6, 2019
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this and it works fine. Thanks @NomadBlacky! 👍

LGTM :shipit:

@pmuens pmuens merged commit a3df5ad into serverless:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants