Test: Ensure to fully cleanup serverless installation when testing plugins
#10250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it leaves a broken symlink of which copying crashes `fse.copy`
Codecov Report
@@ Coverage Diff @@
## master #10250 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 339 339
Lines 13838 13838
=======================================
Hits 11816 11816
Misses 2022 2022 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it leaves a broken symlinks of which copying crashes
fse.copyjprichardson/node-fs-extra#765 (observable in v9 offs-extrawe're still relying on).This issue was responsible for tests not passing in v3 branch once switching to Node.js v16