support dubbo3.x rateLimiting/circuitBreaker #1747
Open
+614
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengyouling
force-pushed
the
develop-rate
branch
from
ce53f9c to
587ca55
Compare
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chengyouling
force-pushed
the
develop-rate
branch
12 times, most recently
from
e55b08f to
81f34b1
Compare
lilai23
reviewed
Feb 24, 2025
lilai23
reviewed
Feb 24, 2025
Comment on lines
+59
to
+60
| mv -f sermant-integration-tests/dubbo-test/dubbo-2-7-integration-provider/src/main/java/io/sermant/integration/ProviderApplication.java.banck sermant-integration-tests/dubbo-test/dubbo-2-7-integration-provider/src/main/java/io/sermant/integration/ProviderApplication.java | ||
| mv -f sermant-integration-tests/dubbo-test/dubbo-2-7-integration-provider/src/main/java/io/sermant/integration/Dubbo3ProviderApplication.java sermant-integration-tests/dubbo-test/dubbo-2-7-integration-provider/src/main/java/io/sermant/integration/Dubbo3ProviderApplication.java.banck |
There was a problem hiding this comment.
what does Dubbo3ProviderApplication.java.banck mean？
There was a problem hiding this comment.
To load the rule file only in the dubbo3 flow control scenario
lilai23
reviewed
Feb 24, 2025
lilai23
reviewed
Feb 24, 2025
...tegration-provider/src/main/java/io/sermant/integration/Dubbo3ProviderApplication.java.banck
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Feb 24, 2025
...provider/src/main/java/io/sermant/integration/configuration/FlowControlExceptionHandler.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Feb 24, 2025
Comment on lines
26
to
30
|
|
||
| /** | ||
| * 流控全局异常处理 | ||
| * | ||
| * @author chengyouling |
There was a problem hiding this comment.
This file exists in consumer. What is the usage here?
There was a problem hiding this comment.
To test the limiting and circuit breaker capabilities of the server in the dubbo scenario
lilai23
reviewed
Feb 24, 2025
Comment on lines
+1
to
+9
| servicecomb: | ||
| matchGroup: | ||
| demo-lb: | | ||
| matches: | ||
| - serviceName: dubbo-integration-provider | ||
| demo-fault-null: | | ||
| matches: | ||
| - apiPath: | ||
| exact: "io.sermant.integration.service.FlowControlService.faultNull" |
There was a problem hiding this comment.
This file exists in consumer. What is the usage here?
There was a problem hiding this comment.
To test the limiting and circuit breaker capabilities of the server in the dubbo scenario
lilai23
reviewed
Feb 24, 2025
Comment on lines
+38
to
+49
| @EnabledIfEnvironmentVariable(named = "TEST_TYPE", matches = "dubbo3-flow") | ||
| public class Dubbo3FlowControlTest { | ||
| private static final String BASE_URL = "http://127.0.0.1:28020/consumer/flow/"; | ||
| private static final int RATE_LIMITING_REQUEST_COUNT = 10; | ||
| private static final int BREAKER_REQUEST_COUNT = 10; | ||
| private static final String BREAKER_MSG = "is OPEN and does not permit further calls"; | ||
| private static final String RATE_LIMITING_MSG = "Rate Limited"; | ||
|
|
||
| /** | ||
| * 限流测试 | ||
| */ | ||
| @Test |
There was a problem hiding this comment.
why copy this class and delete some test case?
There was a problem hiding this comment.
Currently, adapted server governance capability first. The client retry and load balancing capabilities are not adapted
lilai23
reviewed
Feb 24, 2025
...wcontrol-common/src/main/java/io/sermant/flowcontrol/common/util/DubboAttachmentsHelper.java
Outdated
Show resolved
Hide resolved
chengyouling
force-pushed
the
develop-rate
branch
from
9cd4f22 to
52bf9aa
Compare
lilai23
reviewed
Feb 25, 2025
chengyouling
force-pushed
the
develop-rate
branch
from
2bc63aa to
14d639d
Compare
Signed-off-by: chengyouling <[email protected]>
chengyouling
force-pushed
the
develop-rate
branch
from
c25cfb9 to
cc83193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it?
Adapt to the increasing use of dubbo3.x services in the market.
Which issue(s) this PR fixes？
Fixes #1746
Does this PR introduce a user-facing change?
support dubbo3.x rateLimiting/circuitBreaker
Checklist