Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rollingInterval multiplier #323

Closed
wants to merge 1 commit into from
Closed

Added rollingInterval multiplier #323

wants to merge 1 commit into from

Conversation

zubyk
Copy link

@zubyk zubyk commented Sep 25, 2024

Example task: log file must roll every 5 minutes

Call LoggerSinkConfiguration extensions with params

  • rollingInterval = RollingInterval.Minute
  • rollingIntervalDuration = 5

Pull request don't broke backward compatibility, you don't need to change code in exists projects.
rollingIntervalDuration can be ommited, default value is 1.

@bartelink
Copy link
Member

related: #308

@nblumhardt
Copy link
Member

nblumhardt commented Oct 1, 2024

Thanks for the suggestion and PR. This is a valid feature, but not planned as an addition currently. This sink aims to stay fairly simple, with community efforts like Serilog.Sinks.PersistentFile and others filling gaps by implementing less widely-used features. There's a pretty good chance this PR will find a home in one of those. Thanks for proposing it all the same!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants