Add render prop support to ClientOnly #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates non-render prop usage of
children
to avoid issues with using client-only imports on the server.For example, this will cause a problem on the server due to how Remix replaces client only imports with an empty module:
Will give the error:
Error: Element type is invalid: expected a string (for built-in components) or a class/function...
Moving to a render function sidesteps the issue by delaying the call to
jsx
orcreateElement
until the hydrated component runs on the client: