Update to React Router v7 #415

AlemTuzlak · 2024-11-20T16:05:20Z

A lot of issues with this, mainly:
Some types are not exported anymore
The tests fail a lot due to installGlobals missing
The json method has been removed and that kind of changes the dynamic of the whole test suites, and a lot of utils

README.md

Co-authored-by: Sergio Xalambrí <[email protected]>

sergiodxa · 2024-11-20T16:34:41Z

src/server/json-hash.ts

@@ -15,7 +15,7 @@ type ResponseResult<LoaderData> = {
 export async function jsonHash<LoaderData extends Record<string, unknown>>(
 	input: LoaderData,
 	init?: ResponseInit | number,
-): Promise<TypedResponse<ResponseResult<LoaderData>>> {
+): Promise<UNSAFE_DataWithResponseInit<ResponseResult<LoaderData>>> {


I think this could be left for TS to infer it

Yeah I agree, especially now that TypedResponse got nuked out of existence

src/server/named-action.ts

test/common/timers.test.ts

sergiodxa · 2024-11-20T16:36:56Z

test/react/fetcher-type.test.tsx

 import { describe, expect, test } from "vitest";

-import { useFetcher } from "@remix-run/react";
+import { useFetcher } from "react-router";


This import can be merged with the react-router import above

yeah I was using patterns to rename so there might be a few of these around, I think biome can also handle this on it's own if configured, but I might be wrong!

Co-authored-by: Sergio Xalambrí <[email protected]>

README.md

package.json

AlemTuzlak · 2024-11-20T16:58:20Z

@sergiodxa I hope this helps you a bit to get fully there, I am not familiar with the codebase, especially the test setup, so it's a bit over my head on how to fix it and make it work, I also added some breaking changes by changing json to data, as data from react-router does not return a response at all. If you need any other help or feedback let me know, I can also help deploy it with pkg.pr.new if needed so people can test it before the official release!

raulfdm · 2024-11-26T13:00:40Z

@sergiodxa sorry to ask that but does this PR has everything already to be merged and shipped? I'm in middle of remix 2 -> react router 7 migration and this package is the last remaining >.<

If you need any help so we can speed this up, please let me (or us) know

.gitignore

… updating preload path in bunfig.toml

…riables

… interactions

lodi-g · 2024-12-06T23:18:03Z

Hey, cool to see this coming into remix-utils. Are you planning a new major release?

Right now [email protected] prevents the upgrade to RR7:

npm error Found: [email protected]
npm error node_modules/react-router
npm error   react-router@"^7.0.0" from the root project
npm error   react-router@"6.28.0" from @remix-run/[email protected]
npm error   node_modules/@remix-run/react
npm error     peer @remix-run/react@"^2.15.0" from @remix-run/[email protected]
npm error     node_modules/@remix-run/dev
npm error       peer @remix-run/dev@"^2.15.0" from @remix-run/[email protected]
npm error       node_modules/@remix-run/fs-routes
npm error       1 more (@remix-run/route-config)
npm error     peerOptional @remix-run/react@"^2.0.0" from [email protected]
npm error     node_modules/remix-utils
npm error       remix-utils@"^7.7.0" from the root project
npm error   1 more (react-router-dom)

Thanks!

sergiodxa · 2024-12-07T03:56:08Z

I need to ensure tests pass on main before releasing it.

greg-hoarau · 2024-12-09T22:43:52Z

Hey 👋 , do you think you align with the same peerDependencies as React Router for the React version (>=18) ? Thanks!

initial rr7 setup

32be7a3