Introduce Call::current_channel #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixMcFelix
requested changes
Apr 10, 2021
There was a problem hiding this comment.
Thanks for the PR! This is useful, and can be modified easily to account for #47's ConnectionInfo changes when it's time to release that.
Just need an additional comment on a known bug until next breaking due to #47 (since this PR will go into a patch release after #56 is fixed). Apart from that, lgtm!
| @@ -240,6 +240,15 @@ impl Call { | |||
| } | |||
| } | |||
|
|
|||
| /// Returns `id` of the channel, if connected to any. | |||
There was a problem hiding this comment.
Suggested change
| /// Returns `id` of the channel, if connected to any. | |
| /// Returns `id` of the channel, if connected to any. | |
| /// | |
| /// **Note**: The returned `id` will not correctly update if a connected bot | |
| /// is moved between channels manually. This will be fixed in the next | |
| // breaking release. |
There was a problem hiding this comment.
I expanded a bit your suggestion. Check it out
FelixMcFelix
approved these changes
Apr 10, 2021
FelixMcFelix
added a commit
to FelixMcFelix/songbird
that referenced
this pull request
Apr 11, 2021
…ng changes. This commit undoes serenity-rs#64 (and bumps the library MSRV accordingly), and modifies serenity-rs#60 to match the new `Call` connection handling. This was tested using `cargo make ready`, and rustc v1.49.0 on `examples/serenity/voice`.
FelixMcFelix
added a commit
to FelixMcFelix/songbird
that referenced
this pull request
May 6, 2021
…ng changes. This commit undoes serenity-rs#64 (and bumps the library MSRV accordingly), and modifies serenity-rs#60 to match the new `Call` connection handling. This was tested using `cargo make ready`, and rustc v1.49.0 on `examples/serenity/voice`.
FelixMcFelix
added a commit
to FelixMcFelix/songbird
that referenced
this pull request
May 10, 2021
…ng changes. This commit undoes serenity-rs#64 (and bumps the library MSRV accordingly), and modifies serenity-rs#60 to match the new `Call` connection handling. This was tested using `cargo make ready`, and rustc v1.49.0 on `examples/serenity/voice`.
FelixMcFelix
added a commit
to FelixMcFelix/songbird
that referenced
this pull request
Jun 14, 2021
…ng changes. This commit undoes serenity-rs#64 (and bumps the library MSRV accordingly), and modifies serenity-rs#60 to match the new `Call` connection handling. This was tested using `cargo make ready`, and rustc v1.49.0 on `examples/serenity/voice`.
FelixMcFelix
added a commit
to FelixMcFelix/songbird
that referenced
this pull request
Jul 1, 2021
…ng changes. This commit undoes serenity-rs#64 (and bumps the library MSRV accordingly), and modifies serenity-rs#60 to match the new `Call` connection handling. This was tested using `cargo make ready`, and rustc v1.49.0 on `examples/serenity/voice`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how you want to organize connection info and whether channel id should be separate from it.
For now I left it separated, just getting API to access it for user so that I could know whether I need to join new one or not
Fixes #58