Fix(receive): Handle sleds of identical RTP timestamps #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bots joining calls with users seem to provoke large runs of packets with identical timestamps -- the existing logic was intended to handle this catchup case in addition to the normal (+=960) at all times. However, we were checking that a packet was modulo greater-than the next ts, rather than modulo less-than. Simple enough to fix.
FelixMcFelix
added
driver
|
The user who encountered this bug reported the fix as working in Discord. CI failures are unrelated; I'll hack together something to skip those tests on CI shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bots joining calls with users seem to provoke large runs of packets with identical timestamps -- the existing logic was intended to handle this catchup case in addition to the normal (+=960) at all times.
However, we were checking that a packet was modulo greater-than the next ts, rather than modulo less-than. Simple enough to fix.