Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver: Add toggle for softclip #137

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

FelixMcFelix
Copy link
Member

This adds the use_softclip field to Config, which can currently provide a ~10us reduction in mixing cost from both a removed memcpy and the softclip itself.

This PR was tested using cargo make ready.

Closes #134.

This adds the `use_softclip` field to `Config`, which can currently provide a ~10us reduction in mixing cost from both a removed memcpy and the softclip itself.

This PR was tested using cargo make ready.

Closes serenity-rs#134.
@FelixMcFelix FelixMcFelix merged commit f34ffbf into serenity-rs:next Jul 25, 2022
@FelixMcFelix FelixMcFelix deleted the toggle-softclip branch July 25, 2022 16:23
FelixMcFelix added a commit that referenced this pull request Jul 26, 2022
This adds the `use_softclip` field to `Config`, which can currently provide a ~10us reduction in mixing cost from both a removed memcpy and the softclip itself.

This PR was tested using cargo make ready.

Closes #134.
@FelixMcFelix FelixMcFelix added enhancement New feature or request driver Relates to the driver or one of its sub-tasks. labels Jul 27, 2022
FelixMcFelix added a commit to FelixMcFelix/songbird that referenced this pull request Nov 20, 2023
This adds the `use_softclip` field to `Config`, which can currently provide a ~10us reduction in mixing cost from both a removed memcpy and the softclip itself.

This PR was tested using cargo make ready.

Closes serenity-rs#134.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver Relates to the driver or one of its sub-tasks. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant