Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking MSRV change in sub-dependency spinning_top #62

Closed
FelixMcFelix opened this issue Apr 10, 2021 · 0 comments · Fixed by #64
Closed

Breaking MSRV change in sub-dependency spinning_top #62

FelixMcFelix opened this issue Apr 10, 2021 · 0 comments · Fixed by #64
Labels
breaking Will either cause existing code to fail to compile, or cause substantial behaviour changes

Comments

@FelixMcFelix
Copy link
Member

Raised via Discord.

Version 0.2.3 of the above uses the std::hint::spin_loop intrinsic introduced in rustc v1.49.0. Patching this dependency's version to equal 0.2.2 should uphold the current 1.48.0 MSRV.
@FelixMcFelix FelixMcFelix added the breaking Will either cause existing code to fail to compile, or cause substantial behaviour changes label Apr 10, 2021
FelixMcFelix added a commit to FelixMcFelix/songbird that referenced this issue Apr 10, 2021
@FelixMcFelix
Deps: Prevent MSRV breakage via spinning_top
5d63098 
The upstream crate `spinning_top` used newer elements of rustc's std in a patch release, unknowingly bumping its MSRV to 1.49.0. This patch reverts to the older, compatible, version.

This has been tested by manually building `examples/serenity/voice` using rustc v1.48.0.

Closes serenity-rs#62.
@FelixMcFelix FelixMcFelix mentioned this issue Apr 10, 2021
Merged
FelixMcFelix added a commit that referenced this issue Apr 10, 2021
@FelixMcFelix
Deps: Prevent MSRV breakage via spinning_top (#64)
a88b185 
The upstream crate `spinning_top` used newer elements of rustc's std in a patch release, unknowingly bumping its MSRV to 1.49.0. This patch reverts to the older, compatible, version.

This has been tested by manually building `examples/serenity/voice` using rustc v1.48.0.

Closes #62.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Will either cause existing code to fail to compile, or cause substantial behaviour changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deps: Prevent MSRV breakage via spinning_top FelixMcFelix/songbird
1 participant
@FelixMcFelix