-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batching on .extract_faces
to improve performance and utilize GPU in full
#1435
Open
galthran-wq
wants to merge
41
commits into
serengil:master
Choose a base branch
from
galthran-wq:detect-batching
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
f4d18a7
batched detection
galthran-wq 0ad7c57
deepFace batch detection; typing
galthran-wq b38e95c
test batch extract faces
galthran-wq 737ee79
chagne detector interface
galthran-wq b2d6178
opencv pseudo batching
galthran-wq 1bd8335
yolo detect batched
galthran-wq bbf6a55
enhance batched detector test
galthran-wq ba2ff90
mtcnn batching
galthran-wq ad01724
soft test
galthran-wq 799f83c
true batching on detect_faces
galthran-wq 619930c
detection skip
galthran-wq b544a2d
pseudo batched retinaface
galthran-wq 8bfdcf1
test diff detetors
galthran-wq 7e59cdf
lint
galthran-wq 0f67dda
optional MtCnn batching (does not work in python3.8)
galthran-wq c4b4b4a
lint
galthran-wq 60bee4e
detect faces return list of lists on batched inputs
galthran-wq f3d05ef
add a couple to test batch extract faces
galthran-wq 1c825e8
add more models and detector-specific rtol
galthran-wq 1d358aa
pseudo-batching dlib
galthran-wq f5188c8
pseudo-batching centerface
galthran-wq 26e537d
psedu-batching fastmtcnn
galthran-wq 7f04e6b
mediapipe pseudo bathcing
galthran-wq 991566f
yunet pseudobatching
galthran-wq 70b61a7
change interface in a special case
galthran-wq 27dea80
batch test add other detector models
galthran-wq 526ab1b
test numpy array batched input
galthran-wq 988afa6
fix batched numpy array input
galthran-wq 3e34675
lint
galthran-wq 2eb5cac
batch extract faces on single image special case
galthran-wq c30f55c
lint
galthran-wq dc6cb81
batch test assert shape
galthran-wq 6143ed9
clearify test batch extract
galthran-wq c46d886
more shape checks
galthran-wq add4c73
disable mtcnn batching by default due to unexpected behaviour
galthran-wq 93b8af1
comments
galthran-wq 8b1b465
change behaviour in special case batched single image
galthran-wq aae3af0
rm opencv from batch test since it still occasionally fails
galthran-wq 8c7c2cb
refactor detectors to have default detect_faces method that is based …
galthran-wq c5ba4a7
lint
galthran-wq 6a3d14c
Update test_extract_faces.py
galthran-wq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not clear that which subclass is giving this error. IMO, we should print the detector name in the exception message.