ISSUE #1233: Feature refresh_database argument added to method find #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serengil
reviewed
May 17, 2024
serengil
reviewed
May 17, 2024
serengil
reviewed
May 17, 2024
serengil
reviewed
May 17, 2024
|
All resolved in the commit b4a35fe; Thanks for the feedback. |
|
LGTM PS: Pipeline failed because of linting but it mostly related to other files than this PR. I will handle it. |
|
Great. Thanks for the work on this framework! It's been really useful to me. Issue #1233 closed. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets
#1233
What has been done
With this PR, the method refresh_database (boolean) allows the user to choose between sync the pkl file with the database directory and keep it up to date with the files inside that directory or ignore any file changes and do the recognition only with the representations in the pkl file.
Also a logger.info saying that the user is possibly out of sync for better user experience;
How to test