Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbage remains in the emoji image. #68

Closed
magita opened this issue Mar 19, 2020 · 5 comments
Closed

Garbage remains in the emoji image. #68

magita opened this issue Mar 19, 2020 · 5 comments

Comments

@magita
Copy link

magita commented Mar 19, 2020

Thank you for a good library.

Garbage is left in the emoji image as shown by the red circle in the screenshot.
Can't be removed it well?
screenshot

@serebrov
Copy link
Owner

This looks like a CSS related issue, might be related to the styles for search results (it looks like the icons are shifting a bit when searching).

But I've just tried (Mac OS, Google Chrome) and I don't see it:

Screenshot 2020-03-22 at 15 49 59

Please provide more details about the issue:

  • Do you see this issue in the demo app at https://serebrov.github.io/emoji-mart-vue/?
  • Browser and OS where you see the issue.
  • Is the issue only reproduced during search?
  • Is the issue only reproduced for twitter icons or for other sets too?

@magita
Copy link
Author

magita commented Mar 23, 2020

Thank you for the quick reply.

Do you see this issue in the demo app at https://serebrov.github.io/emoji-mart-vue/?

Yes.

Browser and OS where you see the issue.

Chrome + Windows10 -> not reproduced.
Chrome + MacOS Mojave -> always reproduce
Safari + MacOS Mojave -> reproduce by browser screen size

Is the issue only reproduced during search?

No. It is reproduced for the Emoji-tag too.
<emoji :data="emojiindex" emoji="white_heart" set="twitter" :size="32" />

Is the issue only reproduced for twitter icons or for other sets too?

It is reproduced for Apple icon, Facebook icon too.

https://jm-david.github.io/emoji-mart-vue/
Not reproduced here.

@magita
Copy link
Author

magita commented Mar 23, 2020

Additional Information:
https://serebrov.github.io/emoji-mart-vue/
When I access this page, the issue reproduced with iOS + Safari.

serebrov added a commit that referenced this issue Mar 23, 2020
[#68] Fix visible edges of nearby sprite icons
@serebrov
Copy link
Owner

@magita I've just published version 7.0.1 with a fix to npm, please check how it works for you.

@magita
Copy link
Author

magita commented Mar 24, 2020

Thank you for the quick response!
Emoji was displayed successfully!

@magita magita closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants