Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude of categories not correctly working #60

Closed
ithr0n opened this issue Oct 8, 2019 · 3 comments
Closed

Exclude of categories not correctly working #60

ithr0n opened this issue Oct 8, 2019 · 3 comments

Comments

@ithr0n
Copy link

ithr0n commented Oct 8, 2019

new EmojiIndex(data, { exclude: ['recent'] }) does not exclude the recent category.
Instead, new EmojiIndex(data, { exclude: ['people'] }) excludes the recent and people category.

Additionally, after showing the Picker the first category is shown (correctly), but the second category is selected in the view. For example, with every category enabled it shows the recent category, but the people category is selected.

@serebrov
Copy link
Owner

serebrov commented Oct 13, 2019

@ithr0n Thanks, I was able to reproduce the bug with excluding the 'recent' category, and I'll release a fix soon.
Alternative way is to set recent explicitly, as this is a "special" category loaded from the local storage: EmojiIndex(data, {recent: []}).

In my testing, the recent could disappear when people is excluded if recent only has emojis from people. If I add emojis from other categories, then recent is displayed.

Regarding the shifted active category - this comes from the virtual scroller and I don't see a simple fix here. You can try the StaticPicker component that doesn't use virtual scroller.

There is a PR in virtual scroller repository that would fix this issue - Akryum/vue-virtual-scroller#115, but it is there for a long time, not sure if it get's merged any time soon.

serebrov added a commit that referenced this issue Oct 13, 2019
@serebrov
Copy link
Owner

Published version 6.1.2 with the fix to npm.

@serebrov
Copy link
Owner

Closing, hopefully it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants