[FIX] clang-18 #3257
Merged
[FIX] clang-18 #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the ignore type is const, ranges::to does not take const
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
seqan-actions
added
lint
eseiler
force-pushed
the
infra/clang-18
branch
2 times, most recently
from
6bc2c3e to
a93ce7e
Compare
seqan-actions
added
lint
`seqan3::sam_file_input::dummy_ref_type` uses `seqan::views::repeat_n`, which uses `seqan3::detail::take_exactly`. Depending on the range type, `seqan3::detail::take_exactly` will do different things. The types are checked with `if constexpr (seqan3::detail::is_type_specialisation_of_v<..., ...>)`. `seqan3::detail::is_type_specialisation_of_v` will use `seqan3::detail::`transfer_template_args_onto`, which is a type trait exposing a type member that will lead to valid but deprecated templates being instantiated. E.g., `std::basic_string<seqan3::dna5>` is valid and compiles. However, `std::basic_string` instantiates `std::char_traits<seqan3::dna5>`. `std::char_traits` is only defined for the provided character types and LLVM deprecates other specialisations. In summary, the trait will instantiate `using type = std::basic_string<seqan3::dna5>;`. This then generates a deprecation warning or error (with -Werror). The fix is to simplify `is_type_specialisation_of_v` to not use `transfer_template_args_onto`. Same is done with `is_value_specialisation_of_v`, even though it does not create any warnings/errors. `transfer_template_args_onto` is used in other places, while `transfer_template_vargs_onto` is not.
seqan-actions
added
lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll update the CI later.
These are some errors I encountered when updating raptor.