Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Missing include #3252

Merged
merged 2 commits into from
May 7, 2024
Merged

[FIX] Missing include #3252

merged 2 commits into from
May 7, 2024

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented May 6, 2024

Trying to write a BAM file while only using the <seqan3/io/sam_file/output.hpp> include leads to a compile error.

The reference dictionary (header.ref_dict) needs to be printed for an error message:

throw format_error{detail::to_string("Unknown reference name '",
id_source,
"' could "
"not be found in BAM header ref_dict: ",
header.ref_dict,
".")};

But the corresponding debug_stream include, required by to_string, is missing.

I added a separate test for this issue as we need to include only this one header.

The header tests probably do not catch this because they do not instantiate the templates.

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
seqan3 ✅ Ready (Inspect) Visit Preview May 6, 2024 0:22am

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels May 6, 2024
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (f489f67) to head (ff16276).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3252   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         269      269           
  Lines       11872    11872           
=======================================
  Hits        11656    11656           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@eseiler eseiler merged commit bcc142e into seqan:main May 7, 2024
34 checks passed
@eseiler eseiler deleted the fix/include branch May 7, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants