Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): log file/line in python #436

Merged
merged 3 commits into from
Dec 18, 2024
Merged

feat(python): log file/line in python #436

merged 3 commits into from
Dec 18, 2024

Conversation

jnooree
Copy link
Member

@jnooree jnooree commented Dec 18, 2024

Checklist

If the change is related to the source code, tests, or build environments, please also check the following:

  • Does ./scripts/run_clang_tools.sh pass without any warnings?
  • Have you built the project locally without any warnings and errors?
  • Does all tests (if new tests are added, including the new ones) pass?

If you added new feature(s), then also check the following:

  • Did you also add corresponding tests?

Linked Issues

Link the tracking issue(s) of this PR, with the auto-close keywords here:


@jnooree jnooree added the python Related to python interface label Dec 18, 2024
@jnooree jnooree enabled auto-merge December 18, 2024 05:32
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.17%. Comparing base (48c5c93) to head (38b65c3).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files          52       52           
  Lines       12777    12779    +2     
=======================================
+ Hits        11649    11651    +2     
  Misses       1128     1128           
Files with missing lines Coverage Δ
include/nuri/utils.h 97.84% <ø> (ø)
python/src/nuri/_log_interface_module.cpp 80.64% <100.00%> (+0.64%) ⬆️

@jnooree jnooree merged commit d1586db into main Dec 18, 2024
16 checks passed
@jnooree jnooree deleted the python/logging branch December 18, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to python interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant