Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: get version with CMakeExtraUtils #435

Closed
wants to merge 1 commit into from
Closed

Conversation

jnooree
Copy link
Member

@jnooree jnooree commented Dec 17, 2024

Checklist

If the change is related to the source code, tests, or build environments, please also check the following:

  • Does ./scripts/run_clang_tools.sh pass without any warnings?
  • Have you built the project locally without any warnings and errors?
  • Does all tests (if new tests are added, including the new ones) pass?

If you added new feature(s), then also check the following:

  • Did you also add corresponding tests?

Linked Issues

Link the tracking issue(s) of this PR, with the auto-close keywords here:

  • Closes #...

@jnooree jnooree added the build Related to the build system or config label Dec 17, 2024
@jnooree
Copy link
Member Author

jnooree commented Dec 17, 2024

Require updating cmake to v3.20. Defer until we absolutely need this...

@jnooree jnooree closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to the build system or config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant