Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python/tools/tm): provide TM-align interface #416

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Conversation

jnooree
Copy link
Member

@jnooree jnooree commented Nov 29, 2024

Checklist

If the change is related to the source code, tests, or build environments, please also check the following:

  • Does ./scripts/run_clang_tools.sh pass without any warnings?
  • Have you built the project locally without any warnings and errors?
  • Does all tests (if new tests are added, including the new ones) pass?

If you added new feature(s), then also check the following:

  • Did you also add corresponding tests?

Linked Issues

Link the tracking issue(s) of this PR, with the auto-close keywords here:


@jnooree jnooree added docs Improvements or additions to documentation engineering Performance, refactoring, etc. python Related to python interface labels Nov 29, 2024
@jnooree jnooree enabled auto-merge November 29, 2024 07:30
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 90.95745% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (49c6206) to head (25d3b44).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
python/src/nuri/tools/tm_module.cpp 90.24% 12 Missing ⚠️
include/nuri/tools/tm.h 0.00% 3 Missing ⚠️
python/include/nuri/python/utils.h 96.42% 1 Missing ⚠️
src/tools/tm.cpp 97.05% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   90.98%   90.96%   -0.03%     
==========================================
  Files          46       47       +1     
  Lines       12278    12416     +138     
==========================================
+ Hits        11171    11294     +123     
- Misses       1107     1122      +15     
Files with missing lines Coverage Δ
python/include/nuri/python/utils.h 97.90% <96.42%> (-0.46%) ⬇️
src/tools/tm.cpp 95.27% <97.05%> (+0.20%) ⬆️
include/nuri/tools/tm.h 89.28% <0.00%> (-10.72%) ⬇️
python/src/nuri/tools/tm_module.cpp 90.24% <90.24%> (ø)

@jnooree jnooree merged commit 4fd6e86 into main Nov 29, 2024
12 of 14 checks passed
@jnooree jnooree deleted the python/tools/tm branch November 29, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation engineering Performance, refactoring, etc. python Related to python interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant