Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): fetch node/edge data lazily #217

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

jnooree
Copy link
Member

@jnooree jnooree commented Feb 7, 2024

Checklist

If the change is related to the source code, tests, or build environments, please also check the following:

  • Does ./scripts/run_clang_tools.sh pass without any warnings?
  • Have you built the project locally without any warnings and errors?
  • Does all tests (if new tests are added, including the new ones) pass?

If you added new feature(s), then also check the following:

  • Did you also add corresponding tests?

Linked Issues

Link the tracking issue(s) of this PR, with the auto-close keywords here:


Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d7534c3) 91.09% compared to head (c72a2b3) 91.10%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   91.09%   91.10%           
=======================================
  Files          17       17           
  Lines        4078     4080    +2     
=======================================
+ Hits         3715     3717    +2     
  Misses        363      363           
Files Coverage Δ
include/nuri/core/graph.h 97.74% <96.15%> (+<0.01%) ⬆️

@jnooree jnooree merged commit 6a5d39d into main Feb 7, 2024
12 checks passed
@jnooree jnooree deleted the jnooree/issue-216 branch February 7, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch node/edge data lazily
1 participant