check downcased annotation path #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it exists. This fixed a corner case bug associated with annotations being downcased when defined agent config files
echlebek
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48
check downcased annotation path but prefer original uncased annotation key if it exists. This fixed a corner case bug associated with annotations being downcased when defined agent config files.
See the sensu-email-handler for an example.
The email handler plugin currently documents the use camelcase annotation keys, which works fine when the annotations are added to an entity or check via sensuctl or api call. But if those strings are configured as part of the agent's config file, for agents not centrally managed, the annotation keys will be downcased before being written into the entity record.
The new logic will first check the downcased version of the annotation key defined as part of of the plugin options, but will prefer the non-case specific string if it also exists.