Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APIKeys: (67) Added API Key UI #69

Merged
merged 32 commits into from
Jan 23, 2024
Merged

feat(APIKeys: (67) Added API Key UI #69

merged 32 commits into from
Jan 23, 2024

Conversation

JEFFTheDev
Copy link
Collaborator

Some thoughts:

  • Maybe we need to discuss some standardized way of form validation now that we're adding more user generated content features. Currently I've used the snackbar which works fine but best practice might be to have some error messages in the form itself
  • In this PR I chose to have the frontend self-service be a seperate running go program, as discussed this will be changed to be served from a seperate port but still be available from the same program. When our UIs merge we will fix this, same goes for the generic layout package.

@JEFFTheDev JEFFTheDev mentioned this pull request Jan 9, 2024
@JEFFTheDev JEFFTheDev merged commit 8e03045 into main Jan 23, 2024
1 check passed
@JEFFTheDev JEFFTheDev deleted the feat/67-api-key-ui branch January 23, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants