Fix URLs to match rewritten security book chapter #190
Conversation
|
@xelaris I think this should rather be fixed in the documentation. There might be other resources on the Internet linking to the old anchors as well and we can't update all of them. |
|
@xabbuh I agree in principle. Is it possible to keep all previous anchors in the documentation? I think many more link targets has been changed on rewrites (not only this time). Maybe I am wrong. Is it possible to add this anchors in addition? Or how can this achieved? I think it is complicated to track all previous anchors. At least one of the URLs also got a new url. |
|
Yes, that's possible. I'll make a pull request later. If you spot any more anchors that are broken, feel free to report them. Unfortunately, we didn't always take care of them. |
|
Ok, than I'm going to close here and will have a look at your PR to learn how this is done. |
| @@ -319,7 +319,7 @@ private static function patchAcmeDemoBundleConfiguration($appDir, Filesystem $fs | |||
|
|
|||
| # with these settings you can restrict or allow access for different parts | |||
| # of your application based on roles, ip, host or methods | |||
| # http://symfony.com/doc/current/book/security.html#security-book-access-control-matching-options | |||
| # http://symfony.com/doc/current/cookbook/security/access_control.html | |||
There was a problem hiding this comment.
@xelaris Can you reopen here? The first two anchors can be fixed in the docs (see symfony/symfony-docs#4785). This one needs to be changed here since the content was moved.
|
Reopened to complement symfony/symfony-docs#4785. I'm going to change the commit to only fix the last URL here as said by @xabbuh. |
|
PR has been changed |
|
Thank you @xelaris. |
This PR was merged into the 3.0.x-dev branch. Discussion ---------- Fix URLs to match rewritten security book chapter Commits ------- f7eb5ec Fix URL to match rewritten security book chapter
This PR was merged into the 2.3 branch. Discussion ---------- [Book][Security] add back old anchors | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | sensiolabs/SensioDistributionBundle#190 Commits ------- 68f36e3 [Book][Security] add back old anchors
No description provided.