Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted README to reStructuredText and version as plain text file #634

Closed
wants to merge 4 commits into from
Closed

Conversation

StrikerRUS
Copy link
Contributor

@StrikerRUS StrikerRUS commented Oct 4, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • [n/a] I have added necessary documentation about the functionality in the appropriate .md file
  • [n/a] I have added in line documentation to the code I modified

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 4, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #634 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   84.77%   84.74%   -0.03%     
==========================================
  Files          35       34       -1     
  Lines        1156     1154       -2     
  Branches      172      171       -1     
==========================================
- Hits          980      978       -2     
  Misses         90       90              
  Partials       86       86
Impacted Files Coverage Δ
sendgrid/sendgrid.py 92% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1627df7...e36d844. Read the comment docs.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: medium fix is medium in difficulty labels Oct 9, 2018
@thinkingserious
Copy link
Contributor

Hello @StrikerRUS,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hi @StrikerRUS!

Could you please make this PR against the v4 branch? Thanks!

With Best Regards,

Elmer

@StrikerRUS StrikerRUS changed the base branch from master to v4 October 9, 2018 09:30
@StrikerRUS StrikerRUS changed the base branch from v4 to master October 9, 2018 10:01
@StrikerRUS
Copy link
Contributor Author

@thinkingserious I'm so sorry, but I've failed to rebase the branch and moved all changes from this PR to #663.

@StrikerRUS StrikerRUS closed this Oct 9, 2018
@StrikerRUS StrikerRUS deleted the pypi branch October 11, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants