-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
converted README to reStructuredText and version as plain text file #634
Conversation
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
==========================================
- Coverage 84.77% 84.74% -0.03%
==========================================
Files 35 34 -1
Lines 1156 1154 -2
Branches 172 171 -1
==========================================
- Hits 980 978 -2
Misses 90 90
Partials 86 86
Continue to review full report at Codecov.
|
Hello @StrikerRUS, |
Hi @StrikerRUS! Could you please make this PR against the v4 branch? Thanks! With Best Regards, Elmer |
@thinkingserious I'm so sorry, but I've failed to rebase the branch and moved all changes from this PR to #663. |
Checklist
Short description of what this PR does:
__version__
attribute by retrieving it from the plain text file, not by executing the.py
module.README.md
toREADME.rst
(appearance can be checked in this branch https://github.com/StrikerRUS/sendgrid-python/blob/pypi/README.rst), soregister.py
is not needed anymore.