Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing 4.2.0 installs the wrong version of python-http-client #321

Closed
w- opened this issue Jun 22, 2017 · 2 comments
Closed

Installing 4.2.0 installs the wrong version of python-http-client #321

w- opened this issue Jun 22, 2017 · 2 comments
Labels
status: help wanted requesting help from the community type: bug bug in the library

Comments

@w-
Copy link
Contributor

w- commented Jun 22, 2017

Issue Summary

If I install 4.2.0 via pip, it install python-http-client==2.3.0
We should be getting 2.2.1

This breaks things if we are doing error handling using HTTPError from urllib.

Steps to Reproduce

$ pip install sendgrid==4.2.0
Collecting sendgrid==4.2.0
  Using cached sendgrid-4.2.0-py2.py3-none-any.whl
Collecting python-http-client>=2.1.1 (from sendgrid==4.2.0)
  Using cached python_http_client-2.3.0-py2.py3-none-any.whl
Installing collected packages: python-http-client, sendgrid
Successfully installed python-http-client-2.3.0 sendgrid-4.2.0

Technical details:

python 2.7.13
pip 9.0.1

Workaround

FYI if we preinstall 2.2.1 it seems to be ok

$ pip install sendgrid==4.2.0
Collecting sendgrid==4.2.0
  Using cached sendgrid-4.2.0-py2.py3-none-any.whl
Requirement already satisfied: python-http-client>=2.1.1 in ./py_venvs/gfy/lib/python2.7/site-packages (from sendgrid==4.2.0)
Installing collected packages: sendgrid
Successfully installed sendgrid-4.2.0
@thinkingserious thinkingserious added status: help wanted requesting help from the community type: bug bug in the library labels Jun 23, 2017
@thinkingserious
Copy link
Contributor

Thanks for the heads up @w-!

I've added this to our backlog for a fix.

jeff-jk added a commit to jeff-jk/sendgrid-python that referenced this issue Jul 3, 2017
@jeff-jk
Require python-http-client=2.2.1 for debugging sendgrid#321
000f8db
thinkingserious added a commit that referenced this issue Aug 4, 2017
@thinkingserious
Version Bump v4.2.1: Issue #321: Installing 4.2.0 installs the wrong …
0de9775 
…version of python-http-client
@thinkingserious
Copy link
Contributor

Fixed with version 4.2.1

@Pieter19 Pieter19 mentioned this issue Aug 4, 2017
Closed
thinkingserious added a commit that referenced this issue Aug 11, 2017
@thinkingserious
Version Bump v5.0.0: fixes #328 and #321
671ed3b
martey added a commit to mobolic/sendgrid-django that referenced this issue Oct 18, 2018
@martey
Revert to standard urllib error handling.
fc71e8b 
This reverts commit e4dfae4, which
tries to fix elbuo8#74 by importing HTTPError from `python_http_client`. This
change isn't necessary, since the error in elbuo8#74 was being caused by a bug
in `sendgrid-python` which resulted in the wrong version of
`python_http_client` being installed:
sendgrid/sendgrid-python#321

Since the bug is fixed in sendgrid-python 4.2.1, but this library still
uses sendgrid-python 3.5+, I've added additional installation
constraints on `python_http_client` so that it should never install a
version with custom error handling (2.3.0 or above). This constraint
should be removed when we upgrade to `sendgrid-python` 4.
martey added a commit to mobolic/sendgrid-django that referenced this issue Oct 18, 2018
@martey
Revert to standard urllib error handling.
994aeaa 
This reverts commit e4dfae4, which
tries to fix elbuo8#74 by importing HTTPError from `python_http_client`. This
change isn't necessary, since the error in elbuo8#74 was being caused by a bug
in `sendgrid-python` which resulted in the wrong version of
`python_http_client` being installed:
sendgrid/sendgrid-python#321

Since the bug is fixed in `sendgrid-python` 4.2.1, but this library
still uses `sendgrid-python` 3.5+, I've added additional installation
constraints on `python_http_client` so that it should never install a
version with custom error handling (2.3.0 or above). This constraint
should be removed when we upgrade to `sendgrid-python` 4.
@martey martey mentioned this issue Oct 18, 2018
Merged
martey added a commit to mobolic/sendgrid-django that referenced this issue Oct 18, 2018
@martey
Revert to standard urllib error handling.
eddf439 
This reverts commit e4dfae4, which
tries to fix elbuo8#74 by importing HTTPError from `python_http_client`. This
change isn't necessary, since the error in elbuo8#74 was being caused by a bug
in `sendgrid-python` which resulted in the wrong version of
`python_http_client` being installed:
sendgrid/sendgrid-python#321

Since the bug is fixed in `sendgrid-python` 4.2.1, but this library
still uses `sendgrid-python` 3.5+, I've added additional installation
constraints on `python_http_client` so that it should never install a
version with custom error handling (2.3.0 or above). This constraint
should be removed when we upgrade to `sendgrid-python` 4.
martey added a commit to mobolic/sendgrid-django that referenced this issue Jan 27, 2019
@martey
Revert to standard error handling; upgrade pytest.
a3bb4ef 
This reverts commit e4dfae4, which
tries to fix elbuo8#74 by importing HTTPError from `python_http_client`. That
change isn't necessary, since the error in elbuo8#74 was being caused by a bug
in `sendgrid-python` which resulted in the wrong version of
`python_http_client` being installed:
sendgrid/sendgrid-python#321

Since the bug is fixed in `sendgrid-python` 4.2.1, but this library
still uses `sendgrid-python` 3.5+, I've added additional installation
constraints on `python_http_client` so that it should never install a
version with custom error handling (2.3.0 or above). This constraint
should be removed when we upgrade to `sendgrid-python` 4.

This commit also adds a minimum version to pytest. pytest-django
requires pytest>=3.6. To prevent test failures, we need to ensure that
an up-to-date version of pytest is installed.
andriisoldatenko pushed a commit to elbuo8/sendgrid-django that referenced this issue Jan 27, 2019
@martey @andriisoldatenko
Revert to standard error handling; upgrade pytest. (#82)
243fb29 
This reverts commit e4dfae4, which
tries to fix #74 by importing HTTPError from `python_http_client`. That
change isn't necessary, since the error in #74 was being caused by a bug
in `sendgrid-python` which resulted in the wrong version of
`python_http_client` being installed:
sendgrid/sendgrid-python#321

Since the bug is fixed in `sendgrid-python` 4.2.1, but this library
still uses `sendgrid-python` 3.5+, I've added additional installation
constraints on `python_http_client` so that it should never install a
version with custom error handling (2.3.0 or above). This constraint
should be removed when we upgrade to `sendgrid-python` 4.

This commit also adds a minimum version to pytest. pytest-django
requires pytest>=3.6. To prevent test failures, we need to ensure that
an up-to-date version of pytest is installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted requesting help from the community type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thinkingserious @w-